Skip to content

New Crowdin translations #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 1, 2019
Merged

New Crowdin translations #62

merged 18 commits into from
Nov 1, 2019

Conversation

Shekharrajak
Copy link
Member

Enjoy!

@joelachance
Copy link
Collaborator

Nice, looks good!

@joelachance
Copy link
Collaborator

Actually, question here for everyone-- do you think we should default to English, as in we shouldn't nest it under /en? Or keep as it is here?

No preference here.

@Shekharrajak
Copy link
Member Author

Actually, question here for everyone-- do you think we should default to English, as in we shouldn't nest it under /en? Or keep as it is here?

No preference here.

I think it by default it can be in en folder. May be en folder is not needed since our default language is English. I created it just for testing.

@Shekharrajak
Copy link
Member Author

I am merging it (target branch is gsod-newsite #61 ) to test later parts.

@Shekharrajak Shekharrajak merged commit c526c2a into gsod-newsite Nov 1, 2019
@Shekharrajak Shekharrajak deleted the l10n_gsod-newsite branch November 1, 2019 17:30
@rgommers
Copy link
Member

rgommers commented Nov 1, 2019

not having /en but just having numpy.org be English and numpy.org/fr French would be a little cleaner I think.

@Shekharrajak
Copy link
Member Author

Shekharrajak commented Nov 2, 2019

not having /en but just having numpy.org be English and numpy.org/fr French would be a little cleaner I think.

Yes, default folder is en and all the URLs will look numpy.org (not numpy.org/en) 🎉 Commit: f1ea711

@rgommers
Copy link
Member

rgommers commented Nov 2, 2019

awesome:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants