Skip to content

content update for array computing ref #43 #64

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
Nov 15, 2019
Merged

Conversation

shaloo
Copy link
Contributor

@shaloo shaloo commented Oct 30, 2019

This PR contains draft content for "Array Computing" as listed in #43 and outlined in https://numpy.org/neps/nep-0028-website-redesign.html.

@rgommers rgommers self-assigned this Oct 31, 2019
@rgommers
Copy link
Member

Thanks Shaloo, excited to see content! I should have some time late tonight to look at the array computing content. I think we should aim also to make that a little more concrete about what the Python landscape looks like.

shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 1, 2019
@shaloo
Copy link
Contributor Author

shaloo commented Nov 1, 2019

Thanks @rgommers for the inputs. Does this version look okay? Its easy to cut down content for first two paragraphs - if you think so.

In the array computing page, I plan to add array computing landscape diagram - similar to your deck but a bit more organised around timeline.

image

shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 4, 2019
shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 4, 2019
@rgommers
Copy link
Member

rgommers commented Nov 4, 2019

In the array computing page, I plan to add array computing landscape diagram - similar to your deck but a bit more organised around timeline.

That sounds great. I think my diagram has all the needed elements, but I wasn't too happy with how it looked - I'm sure you'll be able to make the visuals and clarity much better.

shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 5, 2019
@shaloo
Copy link
Contributor Author

shaloo commented Nov 11, 2019

Here is how the latest array landscape looks like...
array_c_landscape

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes to make, then I'd like to merge this to keep things moving and avoid further merge conflicts. I'd like to help tweak the language on the array computing page a little, but that can be done later - this is a nice first cut.

Also, can you break the lines so they're about 80-100 characters long? That makes it easier to review and read.

@shaloo
Copy link
Contributor Author

shaloo commented Nov 15, 2019

A few small changes to make, then I'd like to merge this to keep things moving and avoid further merge conflicts. I'd like to help tweak the language on the array computing page a little, but that can be done later - this is a nice first cut.

Also, can you break the lines so they're about 80-100 characters long? That makes it easier to review and read.

Ralf, did you mean line in html sources restricted to 80/100 chars? Done in array computing page src.

@shaloo shaloo requested a review from rgommers November 15, 2019 04:27
@rgommers
Copy link
Member

Ralf, did you mean line in html sources restricted to 80/100 chars?

Yes, I meant any content, html would be quite useful too. If long paragraphs with links are on a single line, then they're very hard to read in the GitHub interface (in an editor you can at least turn on Word Wrap, but diffs will still be tricky).

Copy link
Member

@rgommers rgommers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks quite nice now!

@shaloo if the line wrapping is in progress please push it, otherwise I'm happy to merge as is and deal with that later. I like seeing the first tab on the front page filled!

@rgommers rgommers merged commit ac0e787 into numpy:newsite Nov 15, 2019
@rgommers
Copy link
Member

Merged, thanks @shaloo!

shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 19, 2019
shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 19, 2019
shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 19, 2019
shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 19, 2019
shaloo added a commit to shaloo/numpy.org that referenced this pull request Nov 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants