Skip to content

process.title crashes the nw process #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nebulade opened this issue Feb 15, 2014 · 6 comments
Closed

process.title crashes the nw process #1570

nebulade opened this issue Feb 15, 2014 · 6 comments
Assignees
@rogerwang

Comments

@nebulade
Copy link

A plain <script> process.title = 'foobar'; </script> in the main html file lets the nw application crash right away.

I am not sure which of the webkit processes it would set the title in the first place, but it should not crash.

This happens at least on v0.9.0 on ArchLinux.

Let me know if you need more information.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@vkurchatkin
Copy link

0.8.5 - the same on Mac OS X 10.9.1

@rogerwang rogerwang self-assigned this Feb 27, 2014
@Mithgol
Copy link
Contributor

Mithgol commented Feb 28, 2014

On Windows XP SP3 process.title does not crash the application, but contains some non-Unicode immutable garbage.

(node-webkit console screenshot)

@coreybutler
Copy link

This doesn't crash on Windows 8/8.1 (and doesn't show garbage), but it does crash on OSX 10.9.2.

FWIW, I used this in node-mac to overcome a title display issue. That was written before Mavericks was released... I had things working on OSX 10.8.x. I've had several users complain about this issue on Mavericks.

@1j01
Copy link

1j01 commented Apr 11, 2015

I'm also seeing the unicode garbage on Windows 8.1
Sometimes it returns an empty string
process title

@niemyjski
Copy link

Also getting this garbage.

niemyjski added a commit to exceptionless/Exceptionless.JavaScript that referenced this issue Jun 2, 2015
@niemyjski
Fixed an issue where node client was sending some unicode data which …
30042f5 
…broke event submission.

We need to take a closer look into this in the future...

nwjs/nw.js#1570

http://stackoverflow.com/questions/10430562/how-do-you-remove-unicode-characters-in-javascript
@nwjs-bot
Copy link

This should be working with latest version now.

In 0.13 we changed to an optimized architecture so more features can be supported, see http://nwjs.io/blog/whats-new-in-0.13/ and it's good for keeping up with Chromium upstream -- we released with Node.js v6.0 and new Chromium versions within 1 day after upstream release.

The new version would fixed many issues reported here and we're scrubbing them. This issue is closed as we believe it should be fixed. Please leave a message if it isn't and we'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rogerwang rogerwang

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@rogerwang @nebulade @coreybutler @niemyjski @Mithgol @vkurchatkin @1j01 @nwjs-bot