Support media type parameters for IsMediaTypeJson
#1386
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although not _technically_ a valid extension to JSON according to [the media type definition], it's got a number of services using it for a `v` or `version` parameter, so we should support this as a valid option. This makes sure that we parse it as a valid media type, performing the same checks as we did before by ignoring the parameters. [the media type definition]: https://www.iana.org/assignments/media-types/application/json
|
Awaiting response from #1374 (comment) |
obouchet
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although not technically a valid extension to JSON according to the
media type definition, it's got a number of services using it for a
vor
versionparameter, so we should support this as a valid option.This makes sure that we parse it as a valid media type, performing the
same checks as we did before by ignoring the parameters.
As an alternative to #1374