add unit tests for go type gen function #1423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@elastic.co>
jamietanna
reviewed
Jan 10, 2024
jamietanna
reviewed
Jan 10, 2024
pkg/codegen/schema_test.go
Outdated
| ReadOnly: tt.fields.ReadOnly, | ||
| WriteOnly: tt.fields.WriteOnly, | ||
| } | ||
| assert.Equalf(t, tt.want, p.GoTypeDef(), "GoTypeDef()") |
There was a problem hiding this comment.
Suggested change
| assert.Equalf(t, tt.want, p.GoTypeDef(), "GoTypeDef()") | |
| assert.Equal(t, tt.want, p.GoTypeDef()) |
jamietanna
reviewed
Jan 10, 2024
pkg/codegen/schema_test.go
Outdated
| want: "*int", | ||
| }, | ||
| { | ||
| name: "When field is readOnly and optional and and read only pointer disabled", |
There was a problem hiding this comment.
Suggested change
| name: "When field is readOnly and optional and and read only pointer disabled", | |
| name: "When field is readOnly and optional and read only pointer disabled", |
Signed-off-by: Ashutosh Kumar <ashutosh.kumar@elastic.co>
|
Couple of things to address, then LGTM |
jamietanna
reviewed
Jan 10, 2024
jamietanna
approved these changes
Jan 10, 2024
danicc097
pushed a commit
to danicc097/oapi-codegen
that referenced
this pull request
Aug 31, 2024
As part of follow-up changes we're making changes to `GoTypeDef`, so it's handy to have some confidence that the existing behaviour isn't affected by the changes. Co-authored-by: Ashutosh Kumar <ashutosh.kumar@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds unit test for
GoTypeDef()method.