Remove generation of code to handle optional query parameters #671
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As highlighted in oapi-codegen#658, in the case that a query parameter is optional, and is not JSON, a passthrough type or a styled parameter, we are rendering an empty method. To simplify our generated code, we can only generate it as and when it's required. To make this more readable, we can indent this new optional block in the template. Closes oapi-codegen#658.
adrianpk
pushed a commit
to foorester/oapi-codegen
that referenced
this pull request
Jan 16, 2024
…odegen#671) As highlighted in oapi-codegen#658, in the case that a query parameter is optional, and is not JSON, a passthrough type or a styled parameter, we are rendering an empty method. To simplify our generated code, we can only generate it as and when it's required. To make this more readable, we can indent this new optional block in the template. Closes oapi-codegen#658.
adrianpk
added a commit
to foorester/oapi-codegen
that referenced
this pull request
May 31, 2024
…odegen#671) As highlighted in oapi-codegen#658, in the case that a query parameter is optional, and is not JSON, a passthrough type or a styled parameter, we are rendering an empty method. To simplify our generated code, we can only generate it as and when it's required. To make this more readable, we can indent this new optional block in the template. Closes oapi-codegen#658.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As highlighted in #658, in the case that a query parameter is optional,
and is not JSON, a passthrough type or a styled parameter, we are
rendering an empty method.
To simplify our generated code, we can only generate it as and when it's
required.
To make this more readable, we can indent this new optional block in the
template.
Closes #658.