Hi @MrkGrgsn !

This looks a good change to me.

However, before approving it, and in order to add a little bit of context, could you tell which library are you using and/or how do you use this library ? (sample of code)

Thanks !

Hi @JonathanHuot

I'm working on an ORCID integration with a Django app using requests_oauthlib. The goal is to link the local user account with their ORCID record and later query and retrieve some resources. I'm using the 'Web Application Flow' aka Authorisation Code Grant Type.

I can't link to the source code but the code pre-PR is similar to this simplified example showing the view that handles the redirect from the authorisation server:

class FetchAccessTokenView():
    def get():
        try:
            token = session.fetch_token()
        except MissingCodeError:
            error = request.GET.get('error', None)
            if error:
                if error == 'access_denied':
                    # ask user to reconsider
                elif error == 'temporarily_unavailable':
                    # ask user to try again later
            else:
                #  unexpected, log and provide feedback

Which will break post-PR. On the other hand, you could check the error param prior to calling fetch_token and this would not break post-PR but we're still doing work that oauthlib can do.

With the attached PR, I can simply use the try/except without any extra handling of the error param:

class FetchAccessTokenView():
    def get():
        try:
            token = session.fetch_token()
        except AccessDeniedError:
            # ask user to reconsider
        except TemporarilyUnavailableError
            # ask user to try again later
        except MissingCodeError:
            # unexpected, log and provide feedback