Skip to content

OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor #726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 22, 2020
Merged

OAuth2 LegacyApplicationClient.prepare_request_body now correctly uses the default scope provided in constructor #726

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3a3d366
`LegacyApplicationClient.prepare_request_body` now honors the default…
Apr 9, 2020
32043a5
Made code a one-liner for consistency with BackendApplicationClient
Apr 9, 2020
8b95eef
changelog entry
Apr 9, 2020
6befed7
Merge branch 'master' into master
JonathanHuot Apr 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,8 +34,9 @@ OAuth2.0 Provider - Bugfixes
OAuth2.0 Client - Bugfixes

* #290: Fix Authorization Code's errors processing
* #603: BackendApplication.Client.prepare_request_body use the `scope` argument as intended.
* #603: BackendApplicationClient.prepare_request_body use the `scope` argument as intended.
* #672: Fix edge case when `expires_in=Null`
* #725: LegacyApplicationClient.prepare_request_body now correctly uses the default `scope` provided in constructor

OAuth1.0 Client

Expand Down
1 change: 1 addition & 0 deletions oauthlib/oauth2/rfc6749/clients/legacy_application.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,5 +79,6 @@ def prepare_request_body(self, username, password, body='', scope=None,
"""
kwargs['client_id'] = self.client_id
kwargs['include_client_id'] = include_client_id
scope = self.scope if scope is None else scope
return prepare_token_request(self.grant_type, body=body, username=username,
password=password, scope=scope, **kwargs)