Guard ui_locales.split() #879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9128305
reviewed
Aug 28, 2024
auvipy
requested changes
Oct 17, 2024
auvipy
requested changes
Oct 21, 2024
`request.ui_locales` might already be a list, only split the value if the `split` method is available.
jaap3
commented
Oct 21, 2024
tests/openid/connect/core/endpoints/test_openid_connect_params_handling.py
Show resolved
Hide resolved
auvipy
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request.ui_localesmight already be a list, only split the value if thesplitmethod is available.I'm creating this PR because I ran into an issue with
django-oauth-toolkit, I've added a workaround there:django-oauth/django-oauth-toolkit#1469
Since I'm unsure if this is a bug in
oauthlib, or is caused by unexpected use bydjango-oauth-toolkitI'm suggesting this change here as well.I will add a test if this is deemed an acceptable fix.