Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shortcuts: Enable CTRL+Shift+Z Redo on all platforms #8389

Closed
wants to merge 1 commit into from

Conversation

tanksdude
Copy link
Contributor

Because ImGui is designed to be a developer's debug menu, it makes sense to allow CTRL+Shift+Z redo, and locking it behind Mac OS only made no sense. This PR enables CTRL+Shift+Z redo everywhere and adjusts the relevant text. Sometimes "Shift" was in all caps and other time it wasn't, but I tried to keep the formatting as similar as possible.

In the demo's ShowExampleAppMainMenuBar(), I did not update ImGui::MenuItem("Redo", "CTRL+Y") (line 8276) to mention this, because I didn't think it mattered.

This PR doesn't update the changelog because I feel a regular maintainer should touch that instead of a newcomer like me.

@ocornut
Copy link
Owner

ocornut commented Feb 12, 2025

Hello,
Thanks for your PR.
Could you clarify on which app/platforms CTRL+Shift+Z tends to be typically supported?

@tanksdude
Copy link
Contributor Author

I'm pretty sure it's supported in all modern applications, from VS Code to LibreOffice to Discord to Firefox. I genuinely don't know of any programs that don't support CTRL+Shift+Z redo. The one exception I guess is Windows's File Explorer, which only supports CTRL+Y.

@ocornut
Copy link
Owner

ocornut commented Feb 12, 2025

Thanks for the clarification. I admit I hadn't noticed that before.
Merged as 6916f93 !

@ocornut ocornut closed this Feb 12, 2025
@tanksdude tanksdude deleted the redo-ctrl-shift-z branch February 12, 2025 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants