Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc about plutosvg #8395

Merged
merged 2 commits into from
Feb 13, 2025
Merged

Update doc about plutosvg #8395

merged 2 commits into from
Feb 13, 2025

Conversation

RT2Code
Copy link
Contributor

@RT2Code RT2Code commented Feb 12, 2025

This PR microsoft/vcpkg#43567 added plutovg/plutosvg ports to vcpkg and replaced the lunasvg feature of the imgui port with plutosvg.

@ocornut
Copy link
Owner

ocornut commented Feb 12, 2025

Thanks! This is good news. May i suggest we kept an explicit blurb for manual compiling? But it may be moved after the vcpkg suggestion and compacted into less lines (e.g. "Compile all source files in plutovg/source/*.c + Add include directory: plutovg/include + plutovg/stb" etc.).

@RT2Code
Copy link
Contributor Author

RT2Code commented Feb 12, 2025

Something like this?

Using plutosvg (and plutovg)

  • Add #define IMGUI_ENABLE_FREETYPE_PLUTOSVG in your imconfig.h.
  • Get latest plutosvg binaries or build yourself. Under Windows you may use vcpkg with: vcpkg install plutosvg --triplet=x64-windows. Alternatively, if you build imgui from vcpkg, you just need to enable the plutosvg feature: vcpkg install imgui[plutosvg] --triplet=x64-windows
  • If you prefer to build plutosvg manually:
    • Compilation hints for plutovg: Compile all source files in plutovg/source/*.c + Add include directory: plutovg/include + plutovg/stb
    • Compilation hints for plutosvg: Compile plutosvg/source/plutosvg.c + Add include directory: plutosvg/source + Add define: PLUTOSVG_HAS_FREETYPE + Link with: plutovg, freetype

I removed the build hints because I just try to follow the current documentation style as closely as possible, and as there were none for lunasvg, I assumed you deemed them unimportant if it was provided by vcpkg. Maybe it's best to leave the build instructions as it was before for readability.

@ocornut ocornut merged commit f94a5f0 into ocornut:master Feb 13, 2025
@ocornut
Copy link
Owner

ocornut commented Feb 13, 2025

This is great, thank you!

@RT2Code RT2Code deleted the plutosvg-vcpkg branch February 13, 2025 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants