Skip to content

chore(deps): remove semantic-release #250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 5, 2024
Merged

chore(deps): remove semantic-release #250

merged 1 commit into from
Mar 5, 2024

Conversation

wolfy1339
Copy link
Member

It conflicts with the Octokit dependencies we define

Resolves #ISSUE_NUMBER


Before the change?

  • Semantic release relies on the CJS versions of Octokit, and we rely on the ESM version, which interfere with each other
  • Releases were blocked

After the change?

  • Semantic release is run via npx and no longer interferes with our defined versions
  • Releases are now unblocked

Pull request checklist

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)

Does this introduce a breaking change?

Please see our docs on breaking changes to help!

  • Yes
  • No

It conflicts with the Octokit dependencies we define
@wolfy1339 wolfy1339 added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Mar 5, 2024
Copy link

github-actions bot commented Mar 5, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@gr2m gr2m merged commit 42f0db7 into main Mar 5, 2024
@gr2m gr2m deleted the remove-semantic-release branch March 5, 2024 19:02
Copy link

github-actions bot commented Mar 5, 2024

🎉 This PR is included in version 5.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants