Skip to content

Conversation

kfcampbell
Copy link
Member

I'm going around and removing pika from our dependencies in favor of esbuild and tsc. This module has already been updated to build with tsc, but I forgot to remove an unused pika package from the package.json.

@kfcampbell kfcampbell added the Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR label Jun 1, 2023
@kfcampbell kfcampbell requested review from nickfloyd and wolfy1339 June 1, 2023 22:23
@wolfy1339
Copy link
Member

That plugin adds an unpkg field to the package.json which points to, in this case, the browser build.

Would you mind adding that to the build script

@kfcampbell
Copy link
Member Author

I'm sorry, I'm not quite sure I'm following and we don't have a prior example in any other place where we've replaced pika with esbuild. Do you mind elaborating a bit?

@wolfy1339
Copy link
Member

This is the only repo I have come across yet that had that pika plugin.

That pika plugin adds an unpkg field in the package.json, that field points to the path of the web build, in this case, build-web/index.js

In scripts/build.mjs, we generate the package.json, simply add the following field to it:

{
    unpkg: "dist-web/index.js"
}

See https://github.com/gr2m/pika-plugin-unpkg-field#pika-plugin-unpkg-field for some info

@kfcampbell
Copy link
Member Author

TIL, thank you! I didn't know what unpkg was before today 😬

@kfcampbell kfcampbell merged commit 619f4e5 into main Jun 1, 2023
@kfcampbell kfcampbell deleted the remove-unused-pika-package branch June 1, 2023 23:03
@github-actions
Copy link

github-actions bot commented Jun 7, 2023

🎉 This PR is included in version 6.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants