Skip to content

test: re-activate more tests and convert them to typescript #457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Jul 18, 2024
Merged

test: re-activate more tests and convert them to typescript #457

Changes from 1 commit
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
6408019
fix: activate more tests
Uzlopak Jul 17, 2024
adddb05
fix memory leakage test
Uzlopak Jul 17, 2024
10d624a
fix import
Uzlopak Jul 17, 2024
4ffed38
fix more
Uzlopak Jul 17, 2024
b01a4ae
activate other tests but skip if failing
Uzlopak Jul 17, 2024
e0d5fe5
try to avoid leakage package
Uzlopak Jul 17, 2024
1d1d7ec
more resilient
Uzlopak Jul 17, 2024
4d38a58
fix test
Uzlopak Jul 17, 2024
d76b796
remove register-endpoints test, see https://github.com/octokit/rest.j…
Uzlopak Jul 17, 2024
421068e
activate more tests
Uzlopak Jul 17, 2024
9b54475
unskip one more
Uzlopak Jul 17, 2024
c9b5f6e
enable more
Uzlopak Jul 17, 2024
760b00f
better remove deprecatios... well keep it for now
Uzlopak Jul 17, 2024
286b22a
remove deprecations.test.ts as they are removed already
Uzlopak Jul 17, 2024
3e106b5
agent-ca.test
Uzlopak Jul 17, 2024
bb0d19e
remove obsolete test, compare with https://github.com/octokit/rest.js…
Uzlopak Jul 17, 2024
f3e2850
fix more
Uzlopak Jul 18, 2024
ebb818a
activate one more smoke test
Uzlopak Jul 18, 2024
8d2ea42
activate 1497 test
Uzlopak Jul 18, 2024
eb9ce23
activate another one
Uzlopak Jul 18, 2024
4b757b6
remove otp tests
Uzlopak Jul 18, 2024
fb9177c
remove params-validations.test.ts
Uzlopak Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
activate one more smoke test
  • Loading branch information
@Uzlopak
Uzlopak committed Jul 18, 2024
commit ebb818a5b79ca8cbadb9d6adfa3c1a2e40dc4b4c
6 changes: 3 additions & 3 deletions test/integration/smoke.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ describe("Smoke tests", () => {
expect(octokit.paginate).toBeInstanceOf(Function);
});

it.skip("@octokit/plugin-request-log", () => {
it("@octokit/plugin-request-log", () => {
const mock = fetchMock
.sandbox()
.getOnce("path:/", { status: 200, body: {} })
Expand Down Expand Up @@ -92,9 +92,9 @@ describe("Smoke tests", () => {
},
() => {
expect(consoleStub.debug.mock.calls.length).toEqual(2);
expect(consoleStub.info.mock.calls.length).toEqual(2);
expect(consoleStub.info.mock.calls.length).toEqual(1);
expect(consoleStub.warn.mock.calls.length).toEqual(0);
expect(consoleStub.error.mock.calls.length).toEqual(0);
expect(consoleStub.error.mock.calls.length).toEqual(1);
},
);
});
Expand Down