[IMP] developer: new CLI commands and improvements #14368
+660
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
2d4eb91 to
a772479
Compare
a772479 to
cc3e3fb
Compare
Added the new `i18n` and `module` commands. Added the existing `deploy`, `obfuscate`, `upgrade_code` commands. Reviewed titles to make the commands stand out in the ToC. Removed the no longer present `tsconfig` command. task-4866527
cc3e3fb to
17ab6d6
Compare
Julien00859
requested changes
Aug 25, 2025
| @@ -236,7 +251,7 @@ Database | |||
|
|
|||
| port the database listens on, defaults to 5432 | |||
|
|
|||
| .. option:: --db-filter <filter> | |||
| .. option:: --nb-filter <filter> | |||
There was a problem hiding this comment.
typo
group.add_option("--db-filter", dest="dbfilter", my_default='', metavar="REGEXP",
help="Regular expressions for filtering available databases for Web UI. "
"The expression can use %d (domain) and %h (host) placeholders.")| @@ -654,15 +646,13 @@ and other ``-`` are replaced by ``_`` e.g. :option:`--db-template` becomes | |||
|
|
|||
| Some conversions don't match the pattern: | |||
|
|
|||
| * :option:`--db-filter` becomes ``dbfilter`` | |||
| * `--db-filter` becomes ``dbfilter`` | |||
There was a problem hiding this comment.
:option: should be restored
| ========== | ||
| .. _reference/cmdline/db: | ||
|
|
||
| `db` - Database Management |
There was a problem hiding this comment.
all the other commands use a verb
Suggested change
| `db` - Database Management | |
| `db` - Manage a Database |
|
|
||
| .. option:: --force | ||
|
|
||
| Delete the database if already exists. |
There was a problem hiding this comment.
Suggested change
| Delete the database if already exists. | |
| Delete the database, may it exists already, before initializing the new one. |
|
|
||
| .. option:: --language <language_code> | ||
|
|
||
| Default language for the instance, default 'en_US' |
There was a problem hiding this comment.
--username and --password are using backticks, but here it uses quote. Let's make it consistent.
Suggested change
| Default language for the instance, default 'en_US' | |
| Default language for the instance, default `en_US` |
| Prerequisites: | ||
|
|
||
| - The server must have the module `base_import_module` installed. | ||
| - You must provide administration login credentials for the login. |
There was a problem hiding this comment.
Suggested change
| - You must provide administration login credentials for the login. | |
| - The `--login` selected user must have administration rights. |
|
|
||
| .. option:: --login <username> | ||
|
|
||
| administrative username of the server. Default is `admin`. |
There was a problem hiding this comment.
There is no such thing as a "administrative username". (default admin) for consistency
Suggested change
| administrative username of the server. Default is `admin`. | |
| user with admin rights (default `admin`) |
|
|
||
| .. option:: --password <password> | ||
|
|
||
| administrative password of the server. Default is `admin`. |
There was a problem hiding this comment.
Suggested change
| administrative password of the server. Default is `admin`. | |
| password of the user (default `admin`) |
Comment on lines
+1520
to
+1522
| .. option:: --verify-ssl | ||
|
|
||
| verify the server's SSL certificate, to ensure the target instance is legit. |
There was a problem hiding this comment.
Not for your pull-request. But it strikes me that this flag enables the SSL verification, meaning that it doesn't verify the certificate my default. It should be the contrary, the verify by default and to have a --no-verify-ssl flag to make it insecure.
| All the scripts are doing a best-effort at migrating the source code, but | ||
| they are not silver bullets. | ||
|
|
||
| It allows the use of the :option:`--addons-path <odoo-bin --addons-path>` option. |
There was a problem hiding this comment.
Grammar. It doesn't allow anything. It is compatible with the option.
There was a problem hiding this comment.
Suggested change
| It allows the use of the :option:`--addons-path <odoo-bin --addons-path>` option. | |
| It understands the :option:`--addons-path <odoo-bin --addons-path>` option. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the new
i18nandmodulecommands.Added the existing
deploy,obfuscate,upgrade_codecommands.Reviewed titles to make the commands stand out in the ToC.
Removed the no longer present
tsconfigcommand.Task link
task-4866527