-
Notifications
You must be signed in to change notification settings - Fork 25
Added option to show upvotes and answers as well. #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@kashifo is attempting to deploy a commit to the Omid Nikrah's projects Team on Vercel. A member of the Team first needs to authorize it. |
@omidnikrah Could you please accept my changes (you can leave the last commit - that's accidentally requested for pull) Thanks. |
@@ -1,7 +1,7 @@ | |||
<br> | |||
|
|||
<p align="center"> | |||
<img width="120px" src="https://raw.githubusercontent.com/omidnikrah/github-readme-stackoverflow/master/stackoverflow.svg" /> | |||
<img width="120px" src="https://raw.githubusercontent.com/kashifo/github-readme-stackoverflow/master/stackoverflow.svg" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please revert all the usernames and userIDs to what is in the README file.
@@ -37,6 +37,82 @@ const StackOverflowCard = async (data, theme, layout) => { | |||
</g> | |||
</svg> | |||
`; | |||
} else if (layout === 'full') { | |||
return ` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please DO NOT generate the whole card again for the full
layout, only add those extra data if the layout is full
.
I have added an option to show upvotes and answers as well, these are important metrics too and there was empty space in default UI card.
And I have not touched any of your existing code, This new option works only with a parameter, and I have tested it as well, So it's 100% safe for you to merge it.
Please merge it and make me a contributor in your open-source project.
Appreciate you and your work!
Here's a screenshot of how it looks:
