Skip to content

build: migrate to slnx #415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

build: migrate to slnx #415

wants to merge 3 commits into from

Conversation

WeihanLi
Copy link
Contributor

This PR

  • migrate to slnx

Related Issues

Fixes #411

Notes

Used the migrated slnx file

@codecov Codecov
Copy link

codecov bot commented Mar 31, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.71%. Comparing base (6c23f21) to head (60648db).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #415   +/-   ##
=======================================
  Coverage   85.71%   85.71%           
=======================================
  Files          39       39           
  Lines        1603     1603           
  Branches      171      171           
=======================================
  Hits         1374     1374           
  Misses        191      191           
  Partials       38       38

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

askpt
askpt requested changes Apr 5, 2025
View reviewed changes
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much for your contribution. 👍

Please don't forget to add the following settings to .vscode/settings.json:

"dotnet.defaultSolution": "OpenFeature.slnx",

The C# extension needs that to find the right solution correctly.

WeihanLi and others added 3 commits April 7, 2025 23:57
@WeihanLi
feat: slnx support
9df8dba 
Signed-off-by: Weihan Li <weihanli@outlook.com>
@WeihanLi @askpt
fix: specify the slnx file
0334907 
Co-authored-by: André Silva <2493377+askpt@users.noreply.github.com>
Signed-off-by: Weihan Li <weihanli@outlook.com>
@WeihanLi
feat: specify slnx for vs code settings
60648db 
Signed-off-by: Weihan Li <weihanli@outlook.com>
askpt
askpt approved these changes Apr 7, 2025
View reviewed changes
Copy link
Member

@askpt askpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Now, let's wait for the fix to be released! Thanks again for your contribution.

@askpt askpt changed the title feat: migrate to slnx build: migrate to slnx Apr 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@askpt askpt askpt approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Migrate to SLNX
2 participants
@WeihanLi @askpt