feat: add JSON Schema validation for Flagd provider when in-process mode is used #373
+540
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fix unit tests failing due to change in constructor * Add initial documentation to README * Add ILogger to provider config Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
Signed-off-by: Kyle Julian <38759683+kylejuliandev@users.noreply.github.com>
askpt
reviewed
Apr 30, 2025
| @@ -24,6 +24,7 @@ | |||
| <!-- The generated files will be placed in ./obj/Debug/netstandard2.0/Protos --> | |||
| <PackageReference Include="JsonLogic" Version="5.4.0" /> | |||
| <PackageReference Include="murmurhash" Version="1.0.3" /> | |||
| <PackageReference Include="NJsonSchema" Version="11.2.0" /> | |||
There was a problem hiding this comment.
Will you get a lot of breaking changes if you lower to 11.0.0? Since we are publishing this dependency (NJsonSchema), we shouldn't enforce newest versions.
| return; | ||
| } | ||
|
|
||
| #if NET5_0_OR_GREATER |
There was a problem hiding this comment.
Not as part of this PR, but we should bump the target framework...
Comment on lines
+18
to
+20
| var jsonSchemaValidator = Substitute.For<IJsonSchemaValidator>(); | ||
|
|
||
| var jsonEvaluator = new JsonEvaluator(fixture.Create<string>()); | ||
| var jsonEvaluator = new JsonEvaluator(fixture.Create<string>(), jsonSchemaValidator); |
There was a problem hiding this comment.
A lot of copy-paste here. I think we should move into a ctor, and control the flow here if needs any change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #226
Notes
Not yet quite finished. Needs some unit tests. Initial testing locally seems to suggest it is working as expected
I'm not sure how keen I am on extending FlagdConfig.cs with ILogger. An alternative approach might be to make it more first class by tweaking the constructor of the FlagdProvider.cs
Follow-up Tasks
How to test