Skip to content

ignore GPG Key for fork repos #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2022

Conversation

thomaspoignant
Copy link
Member

@thomaspoignant thomaspoignant commented Jul 24, 2022

This PR ensures that we are signing the jar in our pull request only if it is not a fork repo.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@codecov-commenter
Copy link

codecov-commenter commented Jul 24, 2022

Codecov Report

Merging #38 (c1d6011) into main (1f4b6e0) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main      #38   +/-   ##
=========================================
  Coverage     92.57%   92.57%           
  Complexity       93       93           
=========================================
  Files            20       20           
  Lines           229      229           
  Branches          6        6           
=========================================
  Hits            212      212           
  Misses           12       12           
  Partials          5        5           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
Signed-off-by: Thomas Poignant <thomas.poignant@gofeatureflag.org>
@thomaspoignant thomaspoignant self-assigned this Jul 24, 2022
@thomaspoignant thomaspoignant added the bug Something isn't working label Jul 24, 2022
@thomaspoignant thomaspoignant marked this pull request as ready for review July 24, 2022 09:23
Copy link
Member

@justinabrahms justinabrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind issuing this PR from a fork? :)

Copy link
Member

@justinabrahms justinabrahms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will test this in the other PR

@justinabrahms justinabrahms merged commit 1508c94 into open-feature:main Jul 24, 2022
@thomaspoignant thomaspoignant deleted the issue-36 branch July 25, 2022 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants