Skip to content

Collection of small, breaking changes #65

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Sep 13, 2022
Merged

Conversation

toddbaert
Copy link
Member

@toddbaert toddbaert commented Sep 9, 2022

This is a collection of small (but breaking) changes. I hope these are the last breaking changes before a 1.0rc. I've broken it into 3 commits for easy understanding:

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
@codecov-commenter
Copy link

Codecov Report

Merging #65 (5d26247) into main (35c9c7e) will increase coverage by 0.10%.
The diff coverage is 90.00%.

@@             Coverage Diff              @@
##               main      #65      +/-   ##
============================================
+ Coverage     90.96%   91.07%   +0.10%     
- Complexity      149      151       +2     
============================================
  Files            19       19              
  Lines           332      336       +4     
  Branches          6        6              
============================================
+ Hits            302      306       +4     
  Misses           21       21              
  Partials          9        9              
Flag Coverage Δ
unittests 91.07% <90.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ava/dev/openfeature/javasdk/EvaluationContext.java 70.73% <ø> (ø)
.../java/dev/openfeature/javasdk/FeatureProvider.java 100.00% <ø> (ø)
...c/main/java/dev/openfeature/javasdk/Structure.java 96.00% <ø> (ø)
src/main/java/dev/openfeature/javasdk/Value.java 86.44% <87.50%> (+0.98%) ⬆️
...ain/java/dev/openfeature/javasdk/NoOpProvider.java 96.55% <100.00%> (ø)
...ava/dev/openfeature/javasdk/OpenFeatureClient.java 97.53% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@toddbaert toddbaert changed the title Breaking changes Collection of small, breaking changes Sep 9, 2022
@justinabrahms
Copy link
Member

Can you also delete the Structure object since we're not using it anymore?

@toddbaert
Copy link
Member Author

toddbaert commented Sep 9, 2022

Can you also delete the Structure object since we're not using it anymore?

We are still using it, in fact, it's quite important. A value can BE a structure (that would be a JSON node that contains a JSON object, in JSON context). You can see it used in Value.asStructure().

It's also still encapsulated in EvaluationContext with lombok, as before.

@justinabrahms
Copy link
Member

@toddbaert Gotcha. So structure = json collection, Value = "holder of some json node"

Signed-off-by: Todd Baert <toddbaert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants