-
Notifications
You must be signed in to change notification settings - Fork 43
Collection of small, breaking changes #65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Todd Baert <toddbaert@gmail.com>
Codecov Report
@@ Coverage Diff @@
## main #65 +/- ##
============================================
+ Coverage 90.96% 91.07% +0.10%
- Complexity 149 151 +2
============================================
Files 19 19
Lines 332 336 +4
Branches 6 6
============================================
+ Hits 302 306 +4
Misses 21 21
Partials 9 9
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Can you also delete the Structure object since we're not using it anymore? |
We are still using it, in fact, it's quite important. A value can BE a structure (that would be a JSON node that contains a JSON object, in JSON context). You can see it used in It's also still encapsulated in |
@toddbaert Gotcha. So structure = json collection, Value = "holder of some json node" |
Signed-off-by: Todd Baert <toddbaert@gmail.com>
9662319
to
60fad05
Compare
This is a collection of small (but breaking) changes. I hope these are the last breaking changes before a 1.0rc. I've broken it into 3 commits for easy understanding:
Value
: 0152a1eInstant
instead ofZonedDateTime
(Instant instead of ZonedDateTime #59): 3e62414Value
instead ofStructure
in object resolver (OpenFeature support for array-like flags. spec#138 (comment)): 5d26247