Skip to content

[REFACTOR] Migrate to Java 11 #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
3 tasks
toddbaert opened this issue Mar 14, 2025 · 5 comments · Fixed by #1303
Closed
3 tasks

[REFACTOR] Migrate to Java 11 #1277

toddbaert opened this issue Mar 14, 2025 · 5 comments · Fixed by #1303
Assignees
@abilashini593
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@toddbaert
Copy link
Member

Based on community feedback and communication with known adopters, we are now able to move to Java 11.

This migration mostly benefits us as maintainers, since it enables new language features and tooling.

Requirements:

  • update source and target versions for maven-compiler-plugin
  • update to use Java 11 language features
    • there might be some helpful tooling for this
    • recommend not changing any tests during "first pass" to make sure no refactors cause undetected regressions
    • no functional changes should be made simultaneously, only refactors and new API usages
  • update any tooling pinned to old versions for Java 8 compatibility

Note:

It's up to individual component owners whether or not they want to consider this a breaking change. The TC will provide a formal recommendation.
@toddbaert toddbaert added good first issue Good for newcomers help wanted Extra attention is needed labels Mar 14, 2025
@abilashini593
Copy link

Hi! I'd love to work on this issue. Could you please assign it to me?

@liran2000 liran2000 mentioned this issue Mar 30, 2025
Draft
@liran2000
Copy link
Member

@abilashini593, @chrfwow can you update on the plan for it ?
it is blocking #1299 and possibly other work.

@abilashini593
Copy link

abilashini593 commented Mar 30, 2025 via email

@liran2000
Copy link
Member

@abilashini593 when do you plan to start?

@jarebudev jarebudev mentioned this issue Apr 9, 2025
Merged
@aepfli
Copy link
Member

aepfli commented Apr 23, 2025

#1303 fixes the majority of CI-related configuration, but we should discuss whether this is already enough to close this issue.

The module-info.java file is something, I think each provider should handle on their own. but do we want to also tackle code improvements, I think we should tackle them separately and this is also in the hands of the provider owners.

wdyt?

FYI: @jarebudev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abilashini593 abilashini593

Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat!: moved sdk-contrib to JDK11 jarebudev/java-sdk-contrib
4 participants
@aepfli @toddbaert @liran2000 @abilashini593