feat: ofrep provider #1429
Merged
feat: ofrep provider #1429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfwow
reviewed
Jun 18, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/Resolver.java
Outdated
Show resolved
Hide resolved
liran2000
reviewed
Jun 19, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/OfrepProviderOptions.java
Outdated
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/OfrepProviderOptions.java
Outdated
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Outdated
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Outdated
Show resolved
Hide resolved
...iders/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepRequest.java
Show resolved
Hide resolved
...ders/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepResponse.java
Show resolved
Hide resolved
providers/ofrep/src/test/java/dev/openfeature/contrib/AppTest.java
Outdated
Show resolved
Hide resolved
bae4f4f to
5ea2826
Compare
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
5ea2826 to
c18d670
Compare
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
liran2000
reviewed
Jun 21, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/OfrepProviderOptions.java
Outdated
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/OfrepProvider.java
Show resolved
Hide resolved
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
liran2000
approved these changes
Jun 22, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Show resolved
Hide resolved
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/OfrepProvider.java
Outdated
Show resolved
Hide resolved
chrfwow
reviewed
Jun 23, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/Resolver.java
Show resolved
Hide resolved
aepfli
approved these changes
Jun 23, 2025
...iders/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepRequest.java
Outdated
Show resolved
Hide resolved
...ders/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepResponse.java
Show resolved
Hide resolved
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
Signed-off-by: Rahul Baradol <rahul.baradol.14@gmail.com>
|
How can we proceed here? |
chrfwow
approved these changes
Jun 30, 2025
|
from my perspective this is good to go, but I would love to have somebody from the OFREP sig also as part of the reviewers @thomaspoignant @lukas-reining (or maybe somebody else) |
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
reviewed
Jul 16, 2025
| */ | ||
| public OfrepApi(Duration requestTimeout, Duration connectTimeout, ProxySelector proxySelector, Executor executor) { | ||
| httpClient = HttpClient.newBuilder() | ||
| .connectTimeout(connectTimeout) |
There was a problem hiding this comment.
We could possibly add keepAlive settings, but by default I think there's a 30s pooled connection so I think that's good for now.
toddbaert
reviewed
Jul 16, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Outdated
Show resolved
Hide resolved
toddbaert
reviewed
Jul 16, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
reviewed
Jul 16, 2025
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
reviewed
Jul 16, 2025
providers/ofrep/src/main/java/dev/openfeature/contrib/providers/ofrep/internal/OfrepApi.java
Show resolved
Hide resolved
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
toddbaert
approved these changes
Jul 16, 2025
There was a problem hiding this comment.
@Rahul-Baradol I made a few very small changes:
- used a
ParseErrorinstead of aGeneralErrorwhere I thought it made sense - updated the parent pom dependency requiring latest SDK version
- added myself to the owners
If that's all OK with you, don't do anything! I will merge tomorrow. If not, please say so!
This was referenced Jul 17, 2025
|
Ohh no issues! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Related Issues
Fixes #1413
Follow-up Tasks