feat: Add dedicated annotations for boolean, String, int and double flags in Junit5 extension #1478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrfwow
reviewed
Jul 7, 2025
| @Test | ||
| @BooleanFlag(name = FLAG, value = true) | ||
| @BooleanFlag(name = FLAG, value = false) | ||
| void duplicatedTypedFlagsSimple() { |
There was a problem hiding this comment.
Please use more descriptive names for your tests, maybe something like duplicateFlagKeyOverridesPreviousDeclaration
|
@ssharaev you will need to force push a commit that is signed off, otherwise the DCO check will not succeed |
…lags in Junit5 extension Signed-off-by: Sviatoslav Sharaev <sviatoslav.sharaev@gmail.com>
d53dc31 to
6777d82
Compare
chrfwow
reviewed
Jul 15, 2025
| @@ -29,6 +37,13 @@ void existingSimpleFlagIsRetrieved() { | |||
| assertThat(client.getDoubleValue(FLAG, FALLBACK)).isEqualTo(FLAG_VALUE); | |||
| } | |||
|
|
|||
| @Test | |||
| @DoubleFlag(name = FLAG, value = 1.d) | |||
There was a problem hiding this comment.
Suggested change
| @DoubleFlag(name = FLAG, value = 1.d) | |
| @DoubleFlag(name = FLAG, value = FLAG_VALUE) |
also for the other tests
Comment on lines
+98
to
+105
| if (domainFlagNames.contains(flagName)) { | ||
| throw new IllegalArgumentException("Flag with name " + flagName + " already exists. " | ||
| + "There shouldn't be @Flag and @" + value.getClass().getSimpleName() + "Flag with the same name!"); | ||
| } | ||
|
|
||
| if (domainFlags.containsKey(flagName)) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
One of these checks is redundant. I think we could even remove the domainFlagNames set entirely, as it contains the same information as the domainFlags map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
BooleanFlag,StringFlag,IntegerFlag, andDoubleFlagfor more specific and type-safe flag definitions in JUnit testsRelated Issues
Fixes #923
Notes
Not sure about tests, feedback on the test coverage is very welcome!