Skip to content

feat: Add Optimizely provider #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

liran2000
Copy link
Member

@liran2000 liran2000 commented Jul 11, 2025

Readme describes the provider.

@jaeopt, @muzahidul-opti @Mat001 you are welcome to review from Optimizely point of view.

Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
@liran2000 liran2000 requested a review from a team as a code owner July 11, 2025 09:16
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Signed-off-by: liran2000 <liran2000@gmail.com>
Copy link
Member

@aepfli aepfli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, there is just one question left, and I think it was a copy paste mistake :)

CHANGELOG.md Outdated
@@ -279,7 +279,7 @@
* **main:** release dev.openfeature.contrib.providers.go-feature-flag 0.4.3 ([#1246](https://github.com/open-feature/java-sdk-contrib/issues/1246)) ([b3bef6a](https://github.com/open-feature/java-sdk-contrib/commit/b3bef6a912080d79733ebb76b3acd4b08c132045))
* **main:** release dev.openfeature.contrib.providers.jsonlogic 1.1.0 ([#616](https://github.com/open-feature/java-sdk-contrib/issues/616)) ([67e8572](https://github.com/open-feature/java-sdk-contrib/commit/67e85726c114c4c14f17a1fb4fe53808b820bed1))
* **main:** release dev.openfeature.contrib.providers.jsonlogic 1.1.1 ([#838](https://github.com/open-feature/java-sdk-contrib/issues/838)) ([143ecb1](https://github.com/open-feature/java-sdk-contrib/commit/143ecb1183c1430b017537a317f8b606d6c9e124))
* **main:** release dev.openfeature.contrib.providers.statsig 0.1.0 ([#700](https://github.com/open-feature/java-sdk-contrib/issues/700)) ([ac5851e](https://github.com/open-feature/java-sdk-contrib/commit/ac5851e2f0c7257418811626d7cd0ed32857c083))
* **main:** release dev.openfeature.contrib.providers.optimizely 0.1.0 ([#700](https://github.com/open-feature/java-sdk-contrib/issues/700)) ([ac5851e](https://github.com/open-feature/java-sdk-contrib/commit/ac5851e2f0c7257418811626d7cd0ed32857c083))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[question] are we intentionally removing statsig here, or was this just a copy paste mistake?

Copy link
Member Author

@liran2000 liran2000 Jul 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not intentional, reverted

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want this to be in the changelog? Because now the entry is removed completely.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From looking at the changelog, seems to me it is auto generated, I reverted it back to as it was.

Signed-off-by: liran2000 <liran2000@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants