test(flagd): Reduce flakiness of ChannelConnectorTest by using random port #1513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… port The ChannelConnectorTests was flacky on github actions, as it used 8080 all the time for its test. With this change we will use a random port for each test run. Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
aepfli
commented
Jul 14, 2025
.../test/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelConnectorTest.java
Show resolved
Hide resolved
chrfwow
reviewed
Jul 14, 2025
.../test/java/dev/openfeature/contrib/providers/flagd/resolver/common/ChannelConnectorTest.java
Show resolved
Hide resolved
chrfwow
approved these changes
Jul 14, 2025
liran2000
approved these changes
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ChannelConnectorTests were flaky on GitHub actions, as they always used 8080 for their tests. With this change, we will use a random port for each test run.
Theoretically, the same port could still be assigned, but the chance would be much smaller than the fixed port.
How to test?
Start any software that will use port 8080 (e.g., a Docker web server) and run the test. It should pass without any issues.
If you run the same on main, the unit test will fail.