feat(flagd): use test-harness version number for integration tests #120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #120 +/- ##
=======================================
Coverage 94.25% 94.25%
=======================================
Files 14 14
Lines 731 731
=======================================
Hits 689 689
Misses 42 42 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
e6cda56 to
18dd5cd
Compare
gruebel
reviewed
Dec 17, 2024
providers/openfeature-provider-flagd/tests/e2e/flagd_container.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Simon Schrottner <simon.schrottner@dynatrace.com>
It seems like there is something flaky here. I'll check, but I am already working on a different approach for tests with an unstable connection. We don't need an image that is regularly disconnecting, as we're using test containers; we can just kill the container and be faster with our tests. Additionally this should grant us more stability in the tests, as we're in control |
gruebel
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.