Skip to content

fix: Pin the ofrep provider's requests dep >=2.27.0 because of… #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

atmask
Copy link
Contributor

@atmask atmask commented Jan 21, 2025

Description: The ofrep provider uses JSONDecodeError from requests.exceptions. This is not available till requests >= 2.27 so update the package deps in pyproject.toml

Issue: #156

@atmask atmask requested a review from a team as a code owner January 21, 2025 21:12
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.39%. Comparing base (ed121bd) to head (faca578).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #161   +/-   ##
=======================================
  Coverage   94.39%   94.39%           
=======================================
  Files          14       14           
  Lines         749      749           
=======================================
  Hits          707      707           
  Misses         42       42           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the OFREP version bump. The rest looks great. Thanks!

By the way, here's an example of the release automatically bumping the version.
#146

… JSONDecodeError useage

Signed-off-by: atmask <benjaminajm@gmail.com>
@beeme1mr beeme1mr merged commit 9ffc7ec into open-feature:main Jan 21, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants