feat!: update the observability appendix to include the latest otel semcon #306
+33
−27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
Depends on changes in the Weaver tool in OTel. Once Weaver has been updated to support an |
askpt
approved these changes
Apr 21, 2025
Signed-off-by: Michael Beemer <beeme1mr@users.noreply.github.com>
|
I've updated the spec to include all the changes recommended by the OTel team. It's ready to be reviewed but we shouldn't merge it until the OTel tooling has been merged. FYI @kinyoklion |
dyladan
reviewed
Apr 23, 2025
Comment on lines
+69
to
+70
| [^1]: The `variant` field is required if the `value` field is not set. | ||
| [^2]: The `value` field is required if the `variant` field is not set. |
There was a problem hiding this comment.
This is technically correct, but I think it doesn't communicate clearly when you would use one or the other. In openfeature you almost always want variant right? value is only there as a fallback for when variant doesn't exist or isn't meaningful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Notes
Marking as a draft until we find out if
valuecan be moved out from thebody.https://docs.google.com/document/d/1x9hprUaUNlVCZMtFAqBcj6h50ukpT0hCAli7BzgWsTQ/edit?tab=t.0