Provide version major/minor/patch macros #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #2014 +/- ##
=======================================
Coverage 87.32% 87.32%
=======================================
Files 166 166
Lines 4673 4673
=======================================
Hits 4080 4080
Misses 593 593 |
ThomsonTan
reviewed
Mar 3, 2023
| @@ -8,6 +8,10 @@ | |||
|
|
|||
| #define OPENTELEMETRY_ABI_VERSION_NO 1 | |||
| #define OPENTELEMETRY_VERSION "1.8.2" | |||
There was a problem hiding this comment.
Use # operator for preprocessor to define OPENTELEMETRY_VERSION with the new VERSION macros?
There was a problem hiding this comment.
Technically possible, but the resulting code, with OPENTELEMETRY_CONCAT() and OPENTELEMETRY_STRINGIFY(), will be extremely obfuscated.
There is no risk that the string version goes out of sync with major/minor/patch versions, there is a unit test to catch this.
lalitb
approved these changes
Mar 3, 2023
ThomsonTan
approved these changes
Mar 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2012
Changes
Added the following macros:
This is helpful for user code, to support multiple versions in case of incompatible changes.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes