[SDK] Use shared_ptr internally for AttributesProcessor to prevent use-after-free #3457
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
|
Thanks for raising the PR. Could you add a dedicated test to validate the seg fault? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3457 +/- ##
==========================================
+ Coverage 89.88% 89.89% +0.02%
==========================================
Files 212 212
Lines 6941 6942 +1
==========================================
+ Hits 6238 6240 +2
+ Misses 703 702 -1
🚀 New features to boost your workflow:
|
done |
Merged
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3456
Changes
This PR changes metric storage and View class to use
std::shared_ptr<const AttributesProcessor>internally, while the public View API continues to accept astd::unique_ptr. The unique pointer is promoted to a shared pointer inside the View constructor. The change prevents use-after-free when metrics are recorded afterMeterProvidershutdown or destruction.Each metric recording operation now accesses the
AttributesProcessorvia astd::shared_ptrinstead of a raw pointer as before. This adds a minimal overhead due to shared pointer reference counting in recording hot-path, but ensures memory safety, so should be acceptable.For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes