[CI] build iwyu #3459
Merged
[CI] build iwyu #3459
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3459 +/- ##
==========================================
+ Coverage 89.88% 89.89% +0.02%
==========================================
Files 212 212
Lines 6942 6942
==========================================
+ Hits 6239 6240 +1
+ Misses 703 702 -1 🚀 New features to boost your workflow:
|
|
Looks good. Suggested changes: In In the same place, raise It seem recent versions of iwyu report different diagnostics, causing new warnings. Assuming that the new diagnostics with a recent iwyu version are more accurate and corresponds to bugs fixed in the tool, we have no choice but comply with the updated diagnostics then. Warnings to be cleaned in a separate PR, to get down to 0 again. |
…yu in the devcontainer. Remove installing the apt package of iwyu
ThomsonTan
reviewed
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3453
Build iwyu to upgrade to version 0.22 and fix the segfault.
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes