Skip to content

[BUILD] Allow compilation with CXX26 #3464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2025

Conversation

vencislav-georgiev-1A
Copy link
Contributor

@vencislav-georgiev-1A vencislav-georgiev-1A commented Jun 5, 2025

Changes

A trivial patch which allows opentelemetry to be built with CXX26.

I successfully compiled it locally with gcc (GCC) 15.1.1

@vencislav-georgiev-1A vencislav-georgiev-1A requested a review from a team as a code owner June 5, 2025 09:16
Copy link

linux-foundation-easycla bot commented Jun 5, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

netlify bot commented Jun 5, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e14057e
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6842e335ee42a70008613d3c

@vencislav-georgiev-1A vencislav-georgiev-1A force-pushed the feature/CXX26 branch 3 times, most recently from d3425b6 to 615dc71 Compare June 5, 2025 12:37
Copy link

codecov bot commented Jun 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.95%. Comparing base (549f2b0) to head (e14057e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3464      +/-   ##
==========================================
+ Coverage   89.92%   89.95%   +0.03%     
==========================================
  Files         219      219              
  Lines        7041     7041              
==========================================
+ Hits         6331     6333       +2     
+ Misses        710      708       -2     

see 2 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff
Copy link
Member

marcalff commented Jun 6, 2025

/easycla

@marcalff
Copy link
Member

marcalff commented Jun 6, 2025

@vencislav-georgiev-1A

Doing force pushes do not trigger the CI build, it is started manually by maintainers since you are a first time contributor. This is a github security feature.

For the PR to be considered, please sign the CLA.

@marcalff marcalff added pr:waiting-on-cla Waiting on CLA and removed pr:waiting-on-cla Waiting on CLA labels Jun 6, 2025
@marcalff marcalff changed the title Allow compilation with CXX26 [BUILD] Allow compilation with CXX26 Jun 6, 2025
@Romain-Geissler-1A
Copy link
Contributor

@marcalff Yeah sorry for that, I was asking Vencislav to force-push to re-trigger the CLA check, I was unsure how this worked exactly, but we sorted that out internally with the manager of our corporate CLA.

@marcalff
Copy link
Member

marcalff commented Jun 6, 2025

@marcalff Yeah sorry for that, I was asking Vencislav to force-push to re-trigger the CLA check, I was unsure how this worked exactly, but we sorted that out internally with the manager of our corporate CLA.

@Romain-Geissler-1A @vencislav-georgiev-1A

Bonjour,

I somehow suspected you two were related. What does 1A stands for exactly ?

To trigger the CLA check again, the way to do it is just add a comment with /easycla.

@Romain-Geissler-1A
Copy link
Contributor

Romain-Geissler-1A commented Jun 6, 2025

What does 1A stands for exactly ?

Actually I was in a bar with some Red Hat maintainers yesterday and they told us the same thing: "1A" isn't clear to anyone ! "1A" is the code in the travelling industry assigned to our employer "Amadeus". Our competitors are being assigned other similar code "1X" (see some example on this page: https://www.airkiosk.com/airxml/airxml-static.php?page=whatIsGds.html ). But only people in the travel industry knows what it means, so it is effectively quite unclear when we contribute to open source projects indeed.

@marcalff
Copy link
Member

marcalff commented Jun 6, 2025

What does 1A stands for exactly ?

Actually I was in a bar with some Red Hat maintainers yesterday and they told us the same thing: "1A" isn't clear to anyone ! "1A" is the code in the travelling industry assigned to our employer "Amadeus". Our competitors are being assigned other similar code "1X" (see some example on this page: https://www.airkiosk.com/airxml/airxml-static.php?page=whatIsGds.html ). But only people in the travel industry knows what it means, to it is effectively quite unclear when we contribute to open source projects indeed.

Thanks for the clarification. Definitively not a student in first year in France, getting an assignment to contribute to opensource then (some people do that).

And thanks for the contribution.

Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the contribution.

@marcalff marcalff merged commit 53b153c into open-telemetry:main Jun 6, 2025
67 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jun 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants