Skip to content

[REMOVAL] Removed deprecated semantic convention header files. #3475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 16, 2025
Merged

[REMOVAL] Removed deprecated semantic convention header files. #3475

merged 4 commits into from
Jun 16, 2025

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 12, 2025 •
edited
Loading

Fixes #3169

Removed deprecated code, as announced earlier on Nov 9, 2024:

Deprecation is announced as part of the migration to weaver:

* `Version:` release following opentelemetry-cpp 1.17.0
* `Date:` Nov 9, 2024
* `PR:` [PR 3105](https://github.com/open-telemetry/opentelemetry-cpp/pull/3105)

Changes

Please provide a brief description of the changes here.

  • Removed deprecated semantic convention headers.
  • Updated maintainers documentation to reflect the new process with weaver.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Jun 12, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d569ad4
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6850869d3493d600081a6a38

@marcalff marcalff added the removal Removal label Jun 12, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 12, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (3d901a8) to head (d569ad4).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3475      +/-   ##
==========================================
+ Coverage   89.91%   89.92%   +0.02%     
==========================================
  Files         219      219              
  Lines        7042     7042              
==========================================
+ Hits         6331     6332       +1     
+ Misses        711      710       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff marked this pull request as ready for review June 12, 2025 23:37
@marcalff marcalff requested a review from a team as a code owner June 12, 2025 23:37
lalitb
lalitb approved these changes Jun 16, 2025
View reviewed changes
Copy link
Member

@lalitb lalitb left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Although it was deprecated, it's still worth including a changelog entry with migration steps for those who haven't removed it yet.

@marcalff
Copy link
Member Author

LGTM. Although it was deprecated, it's still worth including a changelog entry with migration steps for those who haven't removed it yet.

Good idea, thanks. Implemented, waiting for CI to complete.

@marcalff marcalff merged commit 021490e into open-telemetry:main Jun 16, 2025
70 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan approved these changes

@lalitb lalitb lalitb approved these changes

Assignees
No one assigned
Labels
removal Removal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[REMOVAL] Header files semantic_conventions.h
3 participants
@marcalff @ThomsonTan @lalitb