Skip to content

[REMOVAL] Remove CMake option WITH_REMOVE_METER_PREVIEW #3476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 16, 2025

Conversation

marcalff
Copy link
Member

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Remove CMake option WITH_REMOVE_METER_PREVIEW.

This option is no longer used, see PR #2370.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner June 14, 2025 08:58
Copy link

netlify bot commented Jun 14, 2025

Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 4705fe2
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/68503b36a3563f0008468397

Copy link

codecov bot commented Jun 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.92%. Comparing base (4561fc2) to head (4705fe2).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3476      +/-   ##
==========================================
+ Coverage   89.91%   89.92%   +0.02%     
==========================================
  Files         219      219              
  Lines        7042     7042              
==========================================
+ Hits         6331     6332       +1     
+ Misses        711      710       -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added removal Removal pr:please-review This PR is ready for review and removed pr:please-review This PR is ready for review labels Jun 14, 2025
@ThomsonTan ThomsonTan merged commit 3d901a8 into open-telemetry:main Jun 16, 2025
70 checks passed
malkia added a commit to malkia/opentelemetry-cpp that referenced this pull request Jun 16, 2025
[REMOVAL] Remove CMake option WITH_REMOVE_METER_PREVIEW (open-telemetry#3476)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
removal Removal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants