Skip to content

[Code Health] include-what-you-use cleanup, part 9 #3492

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jun 22, 2025
Merged

[Code Health] include-what-you-use cleanup, part 9 #3492

merged 9 commits into from
Jun 22, 2025

Conversation

marcalff
Copy link
Member

@marcalff marcalff commented Jun 21, 2025 •
edited
Loading

Fixes # (issue)

Changes

Please provide a brief description of the changes here.

  • Fixed all 5 + 28 + 48 include-what-you-use remaining warnings.

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@marcalff marcalff requested a review from a team as a code owner June 21, 2025 18:49
@netlify Netlify
Copy link

netlify bot commented Jun 21, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit e2e7791
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/685744289fcd06000812433f

@codecov Codecov
Copy link

codecov bot commented Jun 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.91%. Comparing base (9708acb) to head (e2e7791).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
- Coverage   89.92%   89.91%   -0.01%     
==========================================
  Files         219      219              
  Lines        7042     7042              
==========================================
- Hits         6332     6331       -1     
- Misses        710      711       +1
Files with missing lines Coverage Δ
sdk/src/logs/batch_log_record_processor.cc 83.12% <ø> (ø)
sdk/src/logs/event_logger.cc 70.59% <ø> (ø)
sdk/src/logs/event_logger_provider.cc 100.00% <ø> (ø)
sdk/src/logs/event_logger_provider_factory.cc 100.00% <ø> (ø)
...metrics/export/periodic_exporting_metric_reader.cc 76.60% <ø> (ø)
sdk/src/metrics/meter.cc 85.89% <ø> (ø)
sdk/src/metrics/meter_context.cc 77.34% <ø> (ø)
sdk/src/metrics/meter_provider.cc 87.18% <ø> (ø)
sdk/src/trace/batch_span_processor.cc 95.95% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff marked this pull request as draft June 21, 2025 19:06
@marcalff marcalff marked this pull request as ready for review June 22, 2025 00:37
@marcalff marcalff added the pr:please-review This PR is ready for review label Jun 22, 2025
dbarker
dbarker approved these changes Jun 22, 2025
View reviewed changes
Copy link
Member

@dbarker dbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@marcalff marcalff merged commit 1d41125 into open-telemetry:main Jun 22, 2025
70 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lalitb lalitb lalitb approved these changes

@dbarker dbarker dbarker approved these changes

Assignees
No one assigned
Labels
pr:please-review This PR is ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@marcalff @lalitb @dbarker