-
Notifications
You must be signed in to change notification settings - Fork 494
[EXPORTER] Add bytes support for OTLP recordables #3495
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EXPORTER] Add bytes support for OTLP recordables #3495
Conversation
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3495 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.02%
==========================================
Files 219 219
Lines 7051 7051
==========================================
+ Hits 6342 6343 +1
+ Misses 709 708 -1 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Unfortunately, as a side effect, this change also enables support for populating byte/uint8 types as span attribute values, which is inconsistent with the specs: Per the spec, an attribute value MUST be one of the following:
Supporting raw bytes or uint8 is not permitted for span attributes. It’s better to enable populating uint8_t as OTLP attributes or body only for logs, not for spans. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As mentioned - #3495 (comment)
Fixes unit test: SetEmptyArrayAttribute Fixes IWYU warnings Only LogRecord accept bytes
777f951
to
310964d
Compare
Thanks, only log record use bytes now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
[EXPORTER] Add bytes support for OTLP recordables (open-telemetry#3495)
Fixes #3487
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.md
updated for non-trivial changes