Skip to content

[CodeHealth] Fix clang-tidy warnings part 2 #3496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Jun 26, 2025
Merged

[CodeHealth] Fix clang-tidy warnings part 2 #3496

merged 20 commits into from
Jun 26, 2025

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jun 24, 2025 •
edited
Loading

Contributes to #2053

Changes

Fixes warnings in the following categories:

  • bugprone-signed-char-misuse
  • bugprone-suspicious-missing-comma
  • bugprone-forward-declaration-namespace
  • bugprone-use-after-move
  • cppcoreguidelines-explicit-virtual-functions
  • cppcoreguidelines-rvalue-reference-param-not-moved
  • cppcoreguidelines-use-default-member-init
  • misc-unused-parameters
  • performance-move-const-arg
  • performance-unnecessary-value-param
  • performance-avoid-endl

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Jun 24, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 22ca025
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/685cf03a8d82d90008eb9b48

@dbarker dbarker changed the title Fix clang tidy warnings part 2 [CodeHealth] Fix clang-tidy warnings part 2 Jun 24, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.96%. Comparing base (8465778) to head (22ca025).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3496      +/-   ##
==========================================
- Coverage   89.99%   89.96%   -0.02%     
==========================================
  Files         219      219              
  Lines        7039     7049      +10     
==========================================
+ Hits         6334     6341       +7     
- Misses        705      708       +3
Files with missing lines Coverage Δ
exporters/ostream/test/ostream_log_test.cc 96.45% <100.00%> (+0.28%) ⬆️
sdk/src/common/global_log_handler.cc 76.20% <100.00%> (-1.08%) ⬇️
sdk/src/trace/span.cc 89.78% <ø> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker dbarker marked this pull request as ready for review June 25, 2025 03:49
@dbarker dbarker requested a review from a team as a code owner June 25, 2025 03:49
dbarker
dbarker commented Jun 25, 2025
View reviewed changes
@dbarker dbarker marked this pull request as draft June 25, 2025 03:55
marcalff
marcalff reviewed Jun 25, 2025
View reviewed changes
@dbarker dbarker marked this pull request as ready for review June 25, 2025 18:00
@dbarker dbarker mentioned this pull request Jun 25, 2025
Merged
3 tasks
marcalff
marcalff approved these changes Jun 25, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the cleanup.

ThomsonTan
ThomsonTan reviewed Jun 25, 2025
View reviewed changes
@marcalff marcalff merged commit f74d413 into open-telemetry:main Jun 26, 2025
70 checks passed
@dbarker dbarker deleted the fix_clang_tidy_warnings_part_2 branch July 10, 2025 16:44
@BrewTestBot BrewTestBot mentioned this pull request Jul 11, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbarker @ThomsonTan @marcalff