Skip to content

[CodeHealth] Fix clang-tidy warnings part 6 #3507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 12, 2025
Merged

[CodeHealth] Fix clang-tidy warnings part 6 #3507

merged 14 commits into from
Jul 12, 2025

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jul 1, 2025 •
edited
Loading

Contributes to #2053

Changes

Fix clang-tidy warnings in otlp grpc and otlp http classes:

  • cppcoreguidelines-avoid-const-or-ref-data-members
  • cppcoreguidelines-special-member-functions
  • cppcoreguidelines-rvalue-reference-param-not-moved
  • performance-unnecessary-value-param

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Jul 1, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit 4844fb1
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/6872803d4a91b10008c53056

@dbarker dbarker changed the title Fix clang tidy warnings part 6 [CodeHealth] Fix clang-tidy warnings part 6 Jul 1, 2025
@codecov Codecov
Copy link

codecov bot commented Jul 1, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.98%. Comparing base (9ee0c27) to head (4844fb1).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3507      +/-   ##
==========================================
+ Coverage   89.97%   89.98%   +0.02%     
==========================================
  Files         219      219              
  Lines        7044     7044              
==========================================
+ Hits         6337     6338       +1     
+ Misses        707      706       -1

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbarker
fix ci issues. HttpSesisonData needs a default constructor. Initializ…
398b422 
…e unintialized members of grpc client options
@dbarker dbarker marked this pull request as ready for review July 1, 2025 18:11
@dbarker dbarker requested a review from a team as a code owner July 1, 2025 18:11
marcalff
marcalff approved these changes Jul 8, 2025
View reviewed changes
Copy link
Member

@marcalff marcalff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@marcalff marcalff mentioned this pull request Jul 10, 2025
Closed
@marcalff marcalff merged commit 62ba4de into open-telemetry:main Jul 12, 2025
70 checks passed
@dbarker dbarker deleted the fix_clang_tidy_warnings_part_6 branch July 13, 2025 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owent owent owent approved these changes

@marcalff marcalff marcalff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dbarker @owent @marcalff @lalitb