[BUILD] Fixes compiling problems in NDK r27 #3517
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
There was a problem hiding this comment.
Pull Request Overview
This PR addresses compilation issues in NDK r27 by reorganizing includes and correcting std::shared_ptr<FILE> usage for file handles.
- Moved the
nlohmann/json.hppinclude to eliminate duplicates. - Replaced the invalid
std::make_shared<FILE>()with a directstd::shared_ptr<FILE>allocation usingfcloseas a deleter.
Comments suppressed due to low confidence (2)
exporters/otlp/src/otlp_file_client.cc:1296
- [nitpick] The variable name
ofis ambiguous; consider renaming it tofile_handleorfile_ptrfor better clarity.
std::shared_ptr<FILE> of = std::shared_ptr<std::FILE>(new_file, fclose);
exporters/otlp/src/otlp_file_client.cc:1239
- Consider adding a unit test to verify that the file handle is correctly opened and closed under NDK r27 to prevent future regressions.
}
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3517 +/- ##
==========================================
+ Coverage 89.95% 89.96% +0.02%
==========================================
Files 219 219
Lines 7051 7051
==========================================
+ Hits 6342 6343 +1
+ Misses 709 708 -1 🚀 New features to boost your workflow:
|
marcalff
approved these changes
Jul 4, 2025
|
@owent Thanks for the std fixes. Will merge once CI completes. |
ThomsonTan
approved these changes
Jul 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3516
Changes
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes