Skip to content

[CMAKE] Add CMake scripts to find or fetch protobuf and grpc #3533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Jul 22, 2025
Merged

[CMAKE] Add CMake scripts to find or fetch protobuf and grpc #3533

merged 14 commits into from
Jul 22, 2025

Conversation

dbarker
Copy link
Member

@dbarker dbarker commented Jul 10, 2025 •
edited
Loading

Fixes #3554

Changes

  • Adds CMake scripts for protobuf and grpc to find installed packages OR fetch from github and build in-tree with otel-cpp
  • Test fetching grpc and protobuf in the CI FetchContent test

For significant contributions please make sure you have completed the following items:

  • CHANGELOG.md updated for non-trivial changes
  • Unit tests have been added
  • Changes in public API reviewed

@netlify Netlify
Copy link

netlify bot commented Jul 10, 2025 •
edited
Loading

✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.

Name Link
🔨 Latest commit d6a2641
🔍 Latest deploy log https://app.netlify.com/projects/opentelemetry-cpp-api-docs/deploys/687fab7848f46b0008a6c185

@codecov Codecov
Copy link

codecov bot commented Jul 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.00%. Comparing base (c406864) to head (cfd1cc6).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3533   +/-   ##
=======================================
  Coverage   90.00%   90.00%           
=======================================
  Files         220      220           
  Lines        7056     7056           
=======================================
  Hits         6350     6350           
  Misses        706      706
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@marcalff marcalff added the pr:fix-merge-conflicts Please fix merge conflicts for this pr label Jul 15, 2025
@dbarker dbarker removed the pr:fix-merge-conflicts Please fix merge conflicts for this pr label Jul 15, 2025
dbarker added 2 commits July 15, 2025 15:15
@dbarker
Merge remote-tracking branch 'origin/main' into cmake_find_or_fetch_p…
19936ab 
…rotobuf_and_grpc
@dbarker
set gRPC_PROTOBUF_PACKAGE_TYPE=CONFIG when installing and building gr…
cc4372d 
…pc to ensure grpc finds protobuf with the CONFIG mode and the libprotobuf TYPE property is set
@dbarker dbarker marked this pull request as ready for review July 16, 2025 01:58
@dbarker dbarker requested a review from a team as a code owner July 16, 2025 01:58
dbarker
dbarker commented Jul 16, 2025
View reviewed changes
dbarker
dbarker commented Jul 16, 2025
View reviewed changes
dbarker
dbarker commented Jul 16, 2025
View reviewed changes
@dbarker dbarker mentioned this pull request Jul 16, 2025
Closed
3 tasks
ThomsonTan
ThomsonTan reviewed Jul 16, 2025
View reviewed changes
owent
owent reviewed Jul 17, 2025
View reviewed changes
owent
owent approved these changes Jul 22, 2025
View reviewed changes
Copy link
Member

@owent owent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks.

@marcalff marcalff merged commit c3a0ac1 into open-telemetry:main Jul 22, 2025
69 checks passed
@dbarker dbarker mentioned this pull request Jul 23, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomsonTan ThomsonTan ThomsonTan left review comments

@owent owent owent approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CMake] Discovery of grpc_cpp_plugin does not work with ALIAS targets
4 participants
@dbarker @ThomsonTan @owent @marcalff