[SDK] Implementation of container resource as per semconv #3572
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
✅ Deploy Preview for opentelemetry-cpp-api-docs canceled.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3572 +/- ##
==========================================
+ Coverage 90.03% 90.08% +0.06%
==========================================
Files 220 222 +2
Lines 7069 7115 +46
==========================================
+ Hits 6364 6409 +45
- Misses 705 706 +1
🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
malkia
reviewed
Jul 29, 2025
lalitb
reviewed
Jul 29, 2025
lalitb
reviewed
Jul 29, 2025
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
lalitb
reviewed
Aug 2, 2025
…hilbhatia08/opentelemetry-cpp into implement_resource_detectors
dbarker
reviewed
Aug 3, 2025
dbarker
reviewed
Aug 3, 2025
dbarker
reviewed
Aug 3, 2025
|
Thanks for the PR @nikhilbhatia08! I think we just need to hash out how best to include these "built-in" detectors in the repo/build systems since many will bring platform dependencies. I've posted my proposal to the initial issue thread. |
hello changes some changes
…hilbhatia08/opentelemetry-cpp into implement_resource_detectors
There was a problem hiding this comment.
Pull Request Overview
This PR implements a container resource detector that extracts container IDs from cgroup information to comply with OpenTelemetry semantic conventions. The implementation focuses specifically on detecting the container.id attribute by parsing /proc/self/cgroup files.
- Adds a new
ContainerResourceDetectorclass that reads container ID from cgroup files - Implements helper functions for parsing container IDs from cgroup file lines using regex
- Adds comprehensive test coverage for container ID extraction logic
Reviewed Changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h | Header file defining the ContainerResourceDetector class and helper functions |
| resource_detectors/container_detector.cc | Implementation of the ContainerResourceDetector::Detect() method |
| resource_detectors/container.cc | Implementation of container ID extraction logic from cgroup files |
| resource_detectors/CMakeLists.txt | CMake configuration for the new resource_detectors library |
| resource_detectors/BUILD | Bazel build configuration for the resource_detectors library |
| sdk/test/resource/resource_test.cc | Test cases for container ID extraction functionality |
| sdk/test/resource/CMakeLists.txt | Updated test dependencies to include resource_detectors |
| sdk/test/resource/BUILD | Updated Bazel test dependencies |
| sdk/src/resource/resource_detector.cc | Refactored environment variable constants to use constexpr |
| CMakeLists.txt | Added resource_detectors subdirectory to build |
lalitb
reviewed
Aug 8, 2025
lalitb
reviewed
Aug 8, 2025
lalitb
reviewed
Aug 8, 2025
lalitb
reviewed
Aug 8, 2025
resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h
Outdated
Show resolved
Hide resolved
lalitb
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
dbarker
reviewed
Aug 8, 2025
resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h
Outdated
Show resolved
Hide resolved
dbarker
reviewed
Aug 8, 2025
resource_detectors/include/opentelemetry/resource_detectors/container_resource_detector.h
Outdated
Show resolved
Hide resolved
dbarker
reviewed
Aug 9, 2025
lalitb
reviewed
Aug 9, 2025
lalitb
approved these changes
Aug 9, 2025
There was a problem hiding this comment.
LGTM, once preview flag is added and approved by @dbarker. Thanks @nikhilbhatia08 for contribution, nice work.
dbarker
reviewed
Aug 10, 2025
dbarker
approved these changes
Aug 10, 2025
|
Thank you so much, @dbarker, @lalitb, and @rafaelroquetto, for helping me with my first contribution! Really appreciate it :) Looking forward to contributing more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # (issue)
Partially fixes #3548
Changes
Added container resource detector only for collecting info about
container.idfrom/proc/self/cgroupand added test coverage to it, but could not add test coverage toDetect()of ContainerResourcePlease provide a brief description of the changes here.
For significant contributions please make sure you have completed the following items:
CHANGELOG.mdupdated for non-trivial changes