fluentd exporter: Add support for DNS name lookup #468
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lalitb
approved these changes
Jul 30, 2024
exporters/fluentd/include/opentelemetry/exporters/fluentd/common/socket_tools.h
Outdated
Show resolved
Hide resolved
exporters/fluentd/include/opentelemetry/exporters/fluentd/common/socket_tools.h
Outdated
Show resolved
Hide resolved
exporters/fluentd/include/opentelemetry/exporters/fluentd/common/socket_tools.h
Show resolved
Hide resolved
|
@justin-mccann could you please take a look at the comments from @lalitb ? |
96a1477 to
edbd02b
Compare
Done; thanks for the reminder, and sorry it was needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for DNS lookups using getaddrinfo(3).
The API supports lookups of hostnames, IPv4, or IPv6 addresses.
This uses the first AF_INET or AF_INET6 address returned
from the list and fails if none is available.
A followup PR triggers new lookups on socket failure.