Ensure that type info is picked up from installed package. #124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually I'm not ensuring anything here anymore, I just hope for the best 😟 I guess I'll need to amend this to test that another package can pick up the type information if opentelemetry-api is installed. |
fdf02d3 to
58d747c
Compare
|
Now, the py.typed installation is checked and even works due to adding MANIFEST.in. 😄 Removing WIP label, as this is now ready for review. |
29fdf42 to
f1af9ff
Compare
reyang
approved these changes
Sep 13, 2019
c24t
approved these changes
Sep 13, 2019
|
We don't type-annotate the SDK (yet 😉) but I can add a MANIFEST.in there too to be future-proof. |
This required moving all top-level modules to a sub-package, to not create collisions with py.typed marker files. See https://www.python.org/dev/peps/pep-0561/#packaging-type-information
f1af9ff to
8579256
Compare
Oberon00
commented
Sep 16, 2019
| opentelemetry.metrics | ||
| opentelemetry.trace | ||
| opentelemetry.util.loader |
There was a problem hiding this comment.
Argh, sorry for the mismerge. --> #138
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-python
that referenced
this pull request
Sep 16, 2019
Oberon00
added a commit
to dynatrace-oss-contrib/opentelemetry-python
that referenced
this pull request
Sep 16, 2019
reyang
pushed a commit
that referenced
this pull request
Sep 16, 2019
srikanthccv
pushed a commit
to srikanthccv/opentelemetry-python
that referenced
this pull request
Nov 1, 2020
Change return type "unknow" to HttpTextFormat for getHttpTextFormat Change return type "unknow" to BinaryFormat for getBinaryFormat Close open-telemetry#124 open-telemetry#123 Signed-off-by: Olivier Albertini <olivier.albertini@montreal.ca>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that type info is picked up from installed package.
This required moving all top-level modules to a sub-package, to not
create collisions with py.typed marker files.
See https://www.python.org/dev/peps/pep-0561/#packaging-type-information