Skip to content

Improve package layout #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jun 26, 2019
Merged

Improve package layout #26

merged 5 commits into from
Jun 26, 2019

Conversation

reyang
Copy link
Member

@reyang reyang commented Jun 24, 2019

Follow up with feedbacks from @Oberon00 on #19.

  1. Fixed the broken link in setup.py.
  2. Use native namespace package since we only support Python 3.4+.
  3. Follow the single source package version practice.

Oberon00
Oberon00 approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@Oberon00 Oberon00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@reyang reyang merged commit 746ce90 into master Jun 26, 2019
@reyang reyang deleted the layout branch June 26, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Oberon00 Oberon00 Oberon00 approved these changes

@c24t c24t Awaiting requested review from c24t

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@reyang @Oberon00