feat: Updated and added examples (logs and metrics) #4559
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
approved these changes
Apr 22, 2025
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
|
Hi @emdneto, So should have caught all now. The CHANGELOG test failed, so I added it to the PR to the unreleased section, but thought it was such a minor alteration that it wouldn't be needed ,so happy to remove if you like |
emdneto
reviewed
Apr 22, 2025
Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
|
doh! thanks for the catch once again @emdneto :). Thats your change committed. |
|
Happy to work on more examples / docs in the future so if you have any in the backlog after this just let me know :) |
lzchen
approved these changes
Apr 23, 2025
This was referenced Apr 25, 2025
DylanRussell
pushed a commit
to DylanRussell/opentelemetry-python
that referenced
this pull request
Apr 29, 2025
) * added examples * Apply suggestions from code review Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> * feat: added examples for metrics and logs * fixed spelling * Update docs/examples/metrics/reader/README.rst Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> --------- Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small PR to update some of the examples we have within the docs folder.
(detailed|normal|basic)docs/examples/logs/example.pyPeriodicExportingMetricReaderto explicitly collect metrics synchronously. This is to provide an example of the workaround for feat: Synchronous Metrics Reader and Exporter #4549Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Does This PR Require a Contrib Repo Change?
Checklist: