Make a BatchProcessor class which both BatchSpanRecordProcessor and BatchLogRecordProcessor can use #4562
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-python into refactor_blrp
xrmx
reviewed
Apr 29, 2025
opentelemetry-sdk/tests/shared_internal/test_batch_processor.py
Outdated
Show resolved
Hide resolved
xrmx
reviewed
Apr 30, 2025
|
Nevermind.. was able to get the test working |
xrmx
approved these changes
May 6, 2025
aabmass
reviewed
May 8, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/export/__init__.py
Outdated
Show resolved
Hide resolved
lzchen
approved these changes
May 12, 2025
…nto refactor_blrp
aabmass
approved these changes
May 12, 2025
opentelemetry-sdk/src/opentelemetry/sdk/_shared_internal/__init__.py
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make a
BatchProcessorclass which bothBatchSpanRecordProcessorandBatchLogRecordProcessorcan use.Move
BatchProcessorinto a new_shared_internalfolder in the SDK, so both processors can make use of it.In a follow up PR, I will update
BatchSpanRecordProcessorto use this new class.Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Added unit tests
Does This PR Require a Contrib Repo Change?
Checklist: