Skip to content

Conversation

jscancella
Copy link
Contributor

Description

I noticed that several of the examples didn't link to their source code on github even though others did. To be consistent I added a link to the example in the README.rst files.

While working on this I also noticed that there was an example for prometheus but no entry in the Read The Docs generated, so I added one following the same style as the other pages.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation

How Has This Been Tested?

generated documentation locally and inspected the html files. I checked all the links and make sure they were pointing to correct github example page.

@jscancella jscancella requested a review from a team as a code owner August 18, 2025 23:28
Copy link

linux-foundation-easycla bot commented Aug 18, 2025

CLA Signed

The committers listed above are authorized under a signed CLA.

@xrmx
Copy link
Contributor

xrmx commented Aug 19, 2025

@jscancella Thanks for the PR but you need to sign the CLA in order to contribute to OpenTelemetry.

@xrmx xrmx moved this to Reviewed PR that needs fixing in @xrmx's Python PR digest Aug 19, 2025
@jscancella
Copy link
Contributor Author

ok, I just signed the agreement. Will it automatically pick that up or is there something else I need to do to kick it off again?

@tammy-baylis-swi
Copy link
Contributor

Please could you also add an entry to the Changelog for this update.

Co-authored-by: Tammy Baylis <96076570+tammy-baylis-swi@users.noreply.github.com>
@jscancella
Copy link
Contributor Author

Please could you also add an entry to the Changelog for this update.

Added an entry - but let me know if there is a different format or anything that needs to be changed

jscancella and others added 3 commits August 21, 2025 17:35
Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
@tammy-baylis-swi tammy-baylis-swi moved this from Reviewed PR that needs fixing to Easy to review / merge / close in @xrmx's Python PR digest Aug 21, 2025
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thank you!

@xrmx xrmx enabled auto-merge (squash) August 22, 2025 14:30
@xrmx xrmx merged commit 05343a5 into open-telemetry:main Aug 22, 2025
371 checks passed
@github-project-automation github-project-automation bot moved this from Easy to review / merge / close to Done in @xrmx's Python PR digest Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants