-
Notifications
You must be signed in to change notification settings - Fork 757
resource-dector-container: package rename to opentelemetry-resource-detector-containerid
#3536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
xrmx
merged 7 commits into
open-telemetry:main
from
emdneto:rename-resource-detector-container
Jun 4, 2025
Merged
resource-dector-container: package rename to opentelemetry-resource-detector-containerid
#3536
xrmx
merged 7 commits into
open-telemetry:main
from
emdneto:rename-resource-detector-container
Jun 4, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emdneto
commented
May 22, 2025
resource/opentelemetry-resource-detector-containerid/tests/test_container.py
Outdated
Show resolved
Hide resolved
aabmass
approved these changes
May 22, 2025
xrmx
requested changes
May 23, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should merge #3429 before renaming
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
6762625
to
b87ad2b
Compare
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
xrmx
approved these changes
Jun 4, 2025
devmonkey22
pushed a commit
to devmonkey22/opentelemetry-python-contrib
that referenced
this pull request
Aug 5, 2025
…detector-containerid` (open-telemetry#3536) * resource-dector-container: package rename Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix ruff Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * change entrypoint Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix test Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * fix for entrypoint name Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * add changelog Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> --------- Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3455
Close #1923
I tested the ./scripts/build.sh and everything is fine, so I expect no problems with the release @open-telemetry/python-maintainers