-
Notifications
You must be signed in to change notification settings - Fork 757
pika: added instrumentation for pika.connection.Connection and pika.c… #3584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pika: added instrumentation for pika.connection.Connection and pika.c… #3584
Conversation
…hannel.Channel, thus added instrumentation support to all SelectConnection adapters.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have much context on Pika but the change looks reasonable to me. If someone with Pika knowledge can review that would be awesome then I'll merge
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Never used Pika but double checked the attribute names for the Channel class and also that the callback function we decorate have the same signature as the blocking one. Do we have tests that are not testing mocks though?
@xrmx I checked the sister |
Maybe there's something in docker-tests, anyway I'll just merge this |
open-telemetry#3584) * pika: added instrumentation for pika.connection.Connection and pika.channel.Channel, thus added instrumentation support to all SelectConnection adapters. * updated changelog. --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
Description
Added support for the pika base connection and channel classes. Thus making all the
SelectConnection
adapters to be automatically instrumented.Fixes #920
Type of change
New feature (non-breaking change which adds functionality)
How Has This Been Tested?
Added relavent tests cases based on current tests for the
opentelemetry-instrumentation-pika
.by running
tox -l | grep sio-pika | xargs -L1 tox -e
Does This PR Require a Core Repo Change?
No.
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.