Update openai instrumentation to use Logs API instead of the deprecated events API
#3628
+52
−62
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests passing now |
|
ACtually before this goes in I think we need to update the SDK Logger to attach the resource to the LogRecord like the SDK EventLogger does: https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py#L654-L764 |
xrmx
reviewed
Aug 27, 2025
| @@ -812,7 +809,7 @@ def chat_completion_multiple_tools_streaming( | |||
|
|
|||
|
|
|||
| def assert_message_in_logs(log, event_name, expected_content, parent_span): | |||
| assert log.log_record.attributes[EventAttributes.EVENT_NAME] == event_name | |||
There was a problem hiding this comment.
Should we keep it for backward compat?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move
openaiinstrumentation from the deprecated events API to the logs API.Type of change
Please delete options that are not relevant.
How Has This Been Tested?
I've updated the existing unit tests to all pass.
Does This PR Require a Core Repo Change?
Checklist:
See contributing.md for styleguide, changelog guidelines, and more.